Skip to content

Conversation

kramlex
Copy link
Contributor

@kramlex kramlex commented Jun 17, 2022

No description provided.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@Alex009 Alex009 changed the base branch from master to develop July 6, 2022 10:51
@Alex009 Alex009 marked this pull request as draft July 6, 2022 10:51
@Alex009 Alex009 changed the title #183 state remastering DRAFT #183 state remastering Jul 6, 2022
@Alex009 Alex009 linked an issue Jul 6, 2022 that may be closed by this pull request
@Alex009
Copy link
Member

Alex009 commented Sep 25, 2022

@kramlex detekt fixes required. check CI runs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kramlex kramlex requested a review from Alex009 September 26, 2022 03:43
@kramlex
Copy link
Contributor Author

kramlex commented Sep 26, 2022

@Alex009 I don't understand. With the use of TestRule in the commonMain source set, the build falls on ubuntu test, and without it it also falls. What to do?

Copy link
Member

@Alex009 Alex009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fix required

Comment on lines -16 to -17
@get:TestRule
val instantTaskExecutorRule = AndroidArchitectureInstantTaskExecutorRule()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

@kramlex
Copy link
Contributor Author

kramlex commented Jan 11, 2023

work has resumed in a new merge request

@kramlex kramlex closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split mvvm-state into components

2 participants