Symfony component Yaml has deprecated Yaml::parse #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this code avoids deprecated error message in current version.
mdwheele
pushed a commit
to mdwheele/opencfp
that referenced
this pull request
Jun 30, 2015
See igorw/ConfigServiceProvider#46 When the above PR is merged, we can revert this commit. The current code is throwing errors in the test suite due to deprecation notices from Yaml::parse. We haven't upgraded this package so no idea why we started getting notices like this but it is what it is. Parse method now triggers a warning if you give it a path. It expects the yaml file contents, not a path. This patch adds a provider that extends Igor's and makes this change. We then sub this provider into the ChainConfigProvider instead of using SilexConfigServiceProvider's default.
mdwheele
pushed a commit
to mdwheele/opencfp
that referenced
this pull request
Jul 6, 2015
See igorw/ConfigServiceProvider#46 When the above PR is merged, we can revert this commit. The current code is throwing errors in the test suite due to deprecation notices from Yaml::parse. We haven't upgraded this package so no idea why we started getting notices like this but it is what it is. Parse method now triggers a warning if you give it a path. It expects the yaml file contents, not a path. This patch adds a provider that extends Igor's and makes this change. We then sub this provider into the ChainConfigProvider instead of using SilexConfigServiceProvider's default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this code avoids deprecated error message in current version.