Async disk bitv flushing (remove mmap) #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikatson
force-pushed
the
mmap-bitv-remove
branch
from
0013df4 to
a865ddd
Compare
mmap was causing random stalls on my slow disk. this happens when a piece is completed and bitv is updated to indicate that. The OS may decide to flush bitv at this time (not at the time we ask), which blocks the hot path. As this happens during TorrentStateLive is locked, other tasks are also blocked by the lock and thus the whole runtime is stalled.
ikatson
force-pushed
the
mmap-bitv-remove
branch
from
a865ddd to
03359ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap was causing random stalls on my slow disk.
this happens when a piece is completed and bitv is updated to indicate that. The OS may decide
to flush bitv at this time (not at the time we ask), which blocks the hot path.
As this happens during TorrentStateLive is locked, other tasks are also blocked by the lock and thus the whole
runtime is stalled.