-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Implement View Helper pattern #3278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # pom.xml
PR SummaryThis PR implements the View Helper design pattern to improve the separation of concerns. It introduces a Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (11)
- 3e1263e: Merge remote-tracking branch 'upstream/master' into 1263-view-helper
Conflicts:
pom.xml
- 9904085: #1263 - creating README and diagrams
- 3dbc8ef: #1263 - keeping module in alphabetical order
- faa7d0a: #1263 - adding license header
- 1e839fa: #1263 - creating main App and its test
- bf56994: #1263 - creating ProductController
- 442e1f8: #1263 - creating Console View for Product
- 69f020b: #1263 - creating ProductViewHelper and its test
- b365be5: #1263 - creating interfaces for View and ViewHelper
- a225935: #1263 - creating Product and ProductViewModel
- a404596: #1263 - creating new module for view-helper
Files Processed (17)
- pom.xml (2 hunks)
- view-helper/README.md (1 hunk)
- view-helper/etc/view-helper-sequence-diagram.png (0 hunks)
- view-helper/etc/view-helper-sequence-diagram.puml (1 hunk)
- view-helper/etc/view-helper.png (0 hunks)
- view-helper/etc/view-helper.puml (1 hunk)
- view-helper/pom.xml (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/App.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ConsoleProductView.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/Product.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductController.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewHelper.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewModel.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/View.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ViewHelper.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/AppTest.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/ProductViewHelperTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Files Processed (16)
- pom.xml (2 hunks)
- view-helper/README.md (1 hunk)
- view-helper/etc/view-helper-sequence-diagram.png (0 hunks)
- view-helper/etc/view-helper-sequence-diagram.puml (1 hunk)
- view-helper/etc/view-helper.png (0 hunks)
- view-helper/etc/view-helper.puml (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/App.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ConsoleProductView.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/Product.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductController.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewHelper.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewModel.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/View.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ViewHelper.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/AppTest.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/ProductViewHelperTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
What does this PR do?
This PR implements the View Helper design pattern to improve the separation of concerns within the application. It introduces a View Helper class responsible for handling data formatting and processing tasks. The Controller is updated to delegate relevant responsibilities to the View Helper, and the View is refactored to consume the prepared data, resulting in cleaner, more maintainable code.
Fixes #1263