-
Notifications
You must be signed in to change notification settings - Fork 243
improve: update multi turn math example with concat as default method #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dhh1995, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the multi-turn math example by bringing it up to date with the latest GRPO framework and adopting the 'concat' mode for data handling. These changes aim to enhance the stability and performance of training results, providing a more robust and efficient foundation for developing multi-turn math agents. The update also includes a model upgrade and introduces an evaluation workflow to ensure comprehensive assessment of the agent's capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the multi-turn math example to use concat as the default method, which provides more stable training. The changes involve refactoring the configuration and the training script for better organization and clarity. I've identified a couple of areas for improvement: one to reduce code duplication in the main function and another to remove an unused variable in the MultiTurnMathAgent. Overall, the changes are a good improvement.
garrett4wade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please respect gemini's comment as well
nuzant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
The multi-turn math example was outdated.
This PR branches from the latest gsm8k grpo example and extends it into a multi-turn math example.
With #668 enabled, the concat mode is now supported and can produce stable training results.
Related Issue
Type of Change
work as expected)
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!