Skip to content

Handle new loop nest constraints during transformation #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Parent: New loop nest constraints (newest nest-constraint PR, directly against main)
wants to merge 18 commits into
base: new-loop-nest-constraints
Choose a base branch
from
Draft

Handle new loop nest constraints during transformation #473

wants to merge 18 commits into from

Conversation

@jdsteve2
Copy link
Collaborator

@jdsteve2 jdsteve2 commented Jul 27, 2021 •
edited
Loading

transformations where loop nest constraints handled:

  • split_iname
  • remove_unused_inames
  • duplicate_inames
  • rename_iname
    • (when new iname doesn't exist)
    • (when new iname DOES exist)
  • (?) tag_inames (currently just erroring if must-nest iname gets tagged as concurrent... anything else need to be done here?
  • join_inames
    • (when within is None)
    • (when within is not None)
  • map_domain

(in progress of moving in/updating relevant functionality from original PR)

jdsteve2 added 18 commits July 27, 2021 16:24
@jdsteve2
add three functions that will be used for updating loop nest constrai…
dd870ea 
…nts during transformation (initially copied in from old loop-nest-constraints-v2 branch with minor changes)
@jdsteve2
refactor replace_inames_in_nest_constraints: move _coalesce_duplicate…
9826e73 
…_inames_in_one_nesting to top level and document; clarify code+comments
@jdsteve2
clearer comments in replace_inames_in_graph
2624ade
@jdsteve2
clean up code/comments in replace_inames_in_all_nest_constraints
3e57099
@jdsteve2
change default arg value from set to frozenset in replace_inames_in_a…
462afed 
…ll_nest_constraints
@jdsteve2
handle nest constraints during split_iname
375a6a2
@jdsteve2
handle nest constraints during remove_unused_inames
1a72273
@jdsteve2
test constraint updating during split_iname
73917af
@jdsteve2
update nest constraints during duplicate_inames
7ba7a36
@jdsteve2
test updating of nest constraints during duplicate_inames
24231cb
@jdsteve2
raise NotImplementedError in rename_iname when there are nest_constra…
c10349f 
…ints and does_exist=True
@jdsteve2
test updating of nest constraints during rename_iname
335cbd9
@jdsteve2
check for nest constraint conflicts in tag_inames
2230aaf
@jdsteve2
test checking of nest constraint conflicts in tag_inames
bf2cb81
@jdsteve2
test adding of vec tag that conflicts with a must_nest constraint
bfb7979
@jdsteve2
update loop nest constraints during join_iname; remove pairs_that_mus…
a9d1d38 
…t_not_voilate_constraints arg and processing from replace_inames_in_graph()
@jdsteve2
test updating of nest constraints during join_inames
7f438e6
@jdsteve2
test coalescing of newly created inames (during join_iname)
751ab73
This was referenced Jul 28, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jdsteve2