Skip to content

Conversation

LeTamanoir
Copy link

@LeTamanoir LeTamanoir commented Nov 24, 2024

No description provided.

@reinink
Copy link
Member

reinink commented Dec 13, 2024

What's the purpose of this change?

@wfern
Copy link

wfern commented Dec 13, 2024

@reinink he explains it in detail in the issue: #2103

@pascalbaljet
Copy link
Member

I get the problem, but changing this would be a breaking change, as I know that people are relying on the global Axios instance, for example, to set additional headers to send with each request.

If you can refactor it to something that you can pass as an option/resolver into createInertiaApp(), then I'm fine with it.

@pascalbaljet pascalbaljet added the needs more info/work Needs more info from the author or additional work to get merged label Jun 17, 2025
@LeTamanoir
Copy link
Author

Hey @pascalbaljet sorry I missed your reply, I'll update my PR with your suggestions 👍

@LeTamanoir LeTamanoir closed this Jul 6, 2025
@LeTamanoir LeTamanoir force-pushed the fix-use-local-axios-instance branch from 7bd3831 to cea9dc2 Compare July 6, 2025 11:31
@LeTamanoir LeTamanoir reopened this Jul 6, 2025
@LeTamanoir LeTamanoir changed the title fix: use local axios instance instead of global feat: allow passing custom axios instance to createInertiaApp Jul 6, 2025
@LeTamanoir LeTamanoir force-pushed the fix-use-local-axios-instance branch from 0ef6980 to 3015120 Compare July 6, 2025 12:47
@LeTamanoir
Copy link
Author

Hey @pascalbaljet I updated the PR.
I went with a static property as it seemed to need less code to change.
Not sure if it fits the code style of the project though 🫤 what do you think ?

@LeTamanoir LeTamanoir marked this pull request as ready for review July 6, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info/work Needs more info from the author or additional work to get merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants