Skip to content

fix(core): Fix issue where anchor scroll randomly doesn't work when React page loads #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(core): Fix issue where anchor scroll randomly doesn't work when React page loads #2707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/core/src/scroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,12 @@ export class Scroll {
this.save()

if (anchorHash) {
// We're using a setTimeout() here as a workaround for a bug in the React adapter where the
// rendering isn't completing fast enough, causing the anchor link to not be scrolled to.
setTimeout(() => {
const anchorElement = document.getElementById(anchorHash.slice(1))
anchorElement ? anchorElement.scrollIntoView() : window.scrollTo(0, 0)
// Using double requestAnimationFrame to wait for the browser to complete the current render cycle
window.requestAnimationFrame(() => {
window.requestAnimationFrame(() => {
const anchorElement = document.getElementById(anchorHash.slice(1))
anchorElement ? anchorElement.scrollIntoView() : window.scrollTo(0, 0)
})
})
}
}
Expand Down