-
Notifications
You must be signed in to change notification settings - Fork 6
Granular rate limits #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dingo-d
wants to merge
7
commits into
infinum:main
Choose a base branch
from
infobipcth:feature/backport-granular-rate-limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Granular rate limits #539
dingo-d
wants to merge
7
commits into
infinum:main
from
infobipcth:feature/backport-granular-rate-limits
+430
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Mario Borna Mjertan <[email protected]>
--------- Co-authored-by: Mario Borna Mjertan <[email protected]>
--------- Co-authored-by: Mario Borna Mjertan <[email protected]>
This will support a granular rate limiting based on the form ID. We have methods that will write and read from the database, and check if the rate limit was exceeded during request validation. The rate limit can be set up from the settings. --------- Co-authored-by: Mario Borna Mjertan <[email protected]>
--------- Co-authored-by: Mario Borna Mjertan <[email protected]>
Also cleaned the unused class imports in the Validator.php file. --------- Co-authored-by: Mario Borna Mjertan <[email protected]>
Contributor
|
Forms also now have this: #522 Not sure how do these two compare. |
Contributor
Author
|
Activity log shouldn't be the same as this. At least by the name 🤷🏼♂️ |
Member
|
tnx for the PR, I will try to merge this to the next release and see if there are any additional changes necessary. |
Contributor
|
@iruzevic any updates on this? |
Member
|
Will be merged probably next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a port of #498 to v8 of the forms plugin. As mentioned in the original PR:
This PR largely refactors the entire
Securitynamespace, and adds support for granular rate limits (per form), in addition to global rate limits.TL;DR:
Note: I started cleaning up the tests, but I think the automated tests should be refactored, as I keep getting failures like: