feat: Support binary data types for SortMergeJoin on clause (#17431)
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he#17431) * feat: Support binary data types for `SortMergeJoin` `on` clause * Add sql level tests for merge join on binary keys --------- Co-authored-by: Andrew Lamb <[email protected]>
alamb
commented
Sep 8, 2025
| DataType::Utf8 => compare_value!(StringArray), | ||
| DataType::Utf8View => compare_value!(StringViewArray), | ||
| DataType::LargeUtf8 => compare_value!(LargeStringArray), | ||
| DataType::Binary => compare_value!(BinaryArray), |
There was a problem hiding this comment.
The code changes are very small, most of this PR is tests
|
Thanks. I've manually cherry-picked the commit since I don't trust GH to not mess up my linear history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this targets #73 and merging this PR will update that PR
Rationale (why)
@stuartcarnie is working on a PachaTree related feature (see this slack thread) that involves merge join of binary columns
In order to use this feature, we need to backport the change from apache#17431 to DataFusion 49.0.2 on our fork
Changes (what):
git cherry-pick 7b65c5b(cherry pick 7b65c5b from DataFusion) to this branch