Skip to content

Conversation

@erratic-pattern
Copy link

@erratic-pattern erratic-pattern commented Oct 6, 2025

Related tracking issue: https://github.com/influxdata/influxdb_iox/issues/15268

In an effort to bring our fork closer to parity with upstream DataFusion, some patches are being removed.

Included Patches

  1. All patches from Patched DF 49.0.2 (take 1) #73 except those that have been removed (see below)
  2. @wiedld 's patch Apply single patch to ver49.02-a #75
  3. Backport of DataFusion 50 fix for CI runners running out of space: [branch-50] Backport change to avoid debug symbols in ci builds to 50.0.0 apache/datafusion#17795

Removed Patches

  1. chore: default=true for skip_physical_aggregate_schema_check, and add warn logging:
    As @alamb mentions in this comment, we have not seen this warning for several weeks, so it seems safe to remove.

crepererum and others added 12 commits September 5, 2025 12:54
)

Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20)

---
updated-dependencies:
- dependency-name: tracing-subscriber
  dependency-version: 0.3.20
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place.

test: recreating the iox plan:
* demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning

test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution

fix: special case to not remove the needed coalesce
…pache#17003)

* Support centroids config for `approx_percentile_cont_with_weight`

* Match two functions' signature

* Update docs

* Address comments and unify centroids config
…ntile_cont_with_weight` (apache#16999)

* Add sqllogictests

* Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight

* Update docs

* Add documentation and more tests
* feat: support distinct for window

* fix

* fix

* fisx

* fix unparse

* fix test

* fix test

* easy way

* add test

* add comments
…he#17404)

* test: regression test for apache#17372

* test: add more direct regression for apache#17372

* fix: return ALL constants in `EquivalenceProperties::constants`
…he#17431)

* feat: Support binary data types for `SortMergeJoin` `on` clause

* Add sql level tests for merge join on binary keys

---------

Co-authored-by: Andrew Lamb <[email protected]>
* test: reproducer of bug
* fix: make schema names unique for approx_percentile_cont
* test: regression test is now resolved
@alamb
Copy link
Collaborator

alamb commented Oct 8, 2025

Current status is that the CI checks are failing on this branch, due to running out of disk space on the builder.

We have fixed this issue upstream in DataFusion on later versions, but it is still happening here.

I restarted the tests again in the perhaps vain hope we'll get a clean run. If they fail again, I'll see if I can find a workaround to clean get them passing

@alamb
Copy link
Collaborator

alamb commented Oct 10, 2025

I backported a commit from DF 50 to address the CI failure: #77

Hopefully we'll get a clean CI run this time

@alamb
Copy link
Collaborator

alamb commented Oct 10, 2025

Hopefully we'll get a clean CI run this time

We did!

@alamb alamb marked this pull request as ready for review October 10, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants