Do not Seek when named pipe is watched #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on FreeBSD 11.1-STABLE amd64 it fails otherwise...
|
@phemmer Can you review this code? It is applied to one of the patches you did so we might need to update the pull request upstream. |
|
This looks pretty innocuous. Should have no impact on the change I had previously made around this code (#2). Not sure if upstream project is being maintained at this point :-/ |
daniel-ayvar
pushed a commit
to daniel-ayvar/tail
that referenced
this pull request
Feb 21, 2024
At least on FreeBSD 11.1-STABLE amd64 it fails otherwise...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on FreeBSD 11.1-STABLE amd64 it fails otherwise...