Refactor and optimize SeisComp image build #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add multistage build - Minor fix
- Allow dynamic seiscomp version selectin at build time via .env - Clean up docker-services.yaml
- Add db initialization and start service scripts - Some minor fix
- Remove unnecessary sudo and streamline user creation
- Parse status command output to actual check if service is running
- Refactor image build workflow - Minor fix in Dockerfile for SeisComP image
- Enhance Dockerfile metadata
- Split image and filesystem scans in two different steps
Contributor
|
it's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimization in image build process and better management of service initialization and configuration.