Skip to content

chore(cat-voices): revert firefox input workaround #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 20, 2025
Merged

chore(cat-voices): revert firefox input workaround #3300

merged 12 commits into from
Nov 20, 2025

Conversation

@LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Aug 26, 2025 •
edited
Loading

Description

Revert a workaround for Firefox

Related Issue(s)

Closes #2720

Description of Changes

  • revert workaround

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx self-assigned this Aug 26, 2025
@LynxLynxx LynxLynxx mentioned this pull request Aug 26, 2025
Closed
2 tasks
@LynxLynxx LynxLynxx added the no-track Used to skip tracking in Swarmia analytics, etc. label Aug 26, 2025
@damian-molinski damian-molinski added the fyi: qa For information - Quality Assurance team label Sep 3, 2025
@damian-molinski damian-molinski moved this from New to 🔬 Ready For QA in Catalyst Sep 3, 2025
@damian-molinski
Copy link
Contributor

damian-molinski commented Sep 3, 2025

Requires verification from QA workaround is no longer need

@LynxLynxx LynxLynxx requested a review from emiride September 3, 2025 08:25
@LynxLynxx LynxLynxx added the squad: face Frontend Catalyst Experience Team label Sep 8, 2025
@damian-molinski damian-molinski requested review from emiride and removed request for emiride October 9, 2025 06:48
@damian-molinski damian-molinski marked this pull request as ready for review November 11, 2025 13:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/voices/chore/revert-firefox-workaround

dt-iohk
dt-iohk previously approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@dt-iohk dt-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flutter fix was released and we're already using the flutter version which contains it: flutter/flutter#167275

LGTM.

@LynxLynxx LynxLynxx added the review me PR is ready for review label Nov 12, 2025
emiride
emiride approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@emiride emiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on firefox, works as expected

@emiride emiride enabled auto-merge (squash) November 20, 2025 14:06
@emiride emiride merged commit f2b71f9 into main Nov 20, 2025
46 checks passed
@emiride emiride deleted the chore/revert-firefox-workaround branch November 20, 2025 14:24
@github-project-automation github-project-automation bot moved this from 🔬 Ready For QA to ✅ Done in Catalyst Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emiride emiride emiride approved these changes

@dt-iohk dt-iohk dt-iohk left review comments

@damian-molinski damian-molinski Awaiting requested review from damian-molinski damian-molinski is a code owner

@bstolinski bstolinski Awaiting requested review from bstolinski bstolinski is a code owner

Assignees

@LynxLynxx LynxLynxx

Labels

fyi: qa For information - Quality Assurance team no-track Used to skip tracking in Swarmia analytics, etc. review me PR is ready for review squad: face Frontend Catalyst Experience Team

Projects

Catalyst
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Firefox keyboard input broken

5 participants

@LynxLynxx @damian-molinski @emiride @dt-iohk