-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): unification of notifications #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
damian-molinski
merged 14 commits into
feat/incident_reporting_3158
from
feat/unification_of_notifications_3414
Oct 9, 2025
Merged
feat(cat-voices): unification of notifications #3457
damian-molinski
merged 14 commits into
feat/incident_reporting_3158
from
feat/unification_of_notifications_3414
Oct 9, 2025
+567
−720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt-iohk
reviewed
Oct 8, 2025
dt-iohk
reviewed
Oct 8, 2025
catalyst_voices/packages/internal/catalyst_voices_view_models/pubspec.yaml
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Oct 8, 2025
dt-iohk
reviewed
Oct 8, 2025
catalyst_voices/apps/voices/lib/notification/catalyst_notification_listener.dart
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Oct 8, 2025
catalyst_voices/apps/voices/lib/notification/catalyst_notification_text.dart
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Oct 8, 2025
catalyst_voices/apps/voices/lib/pages/account/account_page.dart
Outdated
Show resolved
Hide resolved
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/unification_of_notifications_3414 |
dt-iohk
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bstolinski
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
312a249
into
feat/incident_reporting_3158
45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-track
Used to skip tracking in Swarmia analytics, etc.
squad: face
Frontend Catalyst Experience Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies app wide notification system. Right now it works only for banners but it can be extended to support dialogs and snackbars too
Related Issue(s)
Resolves #3414
Fixes #3142
Description of Changes
CatalystMessenger
andCatalystNotification
as base classes for global banners and notifications system.CatalystNotification
triggered from SessionCubitDemo
Not verified account
account_not_verified_demo_1080.mov
Verified account
proposer_banner_demo_1080.mov
Please confirm the following checks