Skip to content

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Sep 22, 2025

Description

This PR unifies app wide notification system. Right now it works only for banners but it can be extended to support dialogs and snackbars too

Related Issue(s)

Resolves #3414
Fixes #3142

Description of Changes

  • Introduces CatalystMessenger and CatalystNotification as base classes for global banners and notifications system.
  • Removed accounts need verification in page banner and replace with CatalystNotification triggered from SessionCubit

Demo

Not verified account

account_not_verified_demo_1080.mov

Verified account

proposer_banner_demo_1080.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski self-assigned this Sep 22, 2025
@damian-molinski damian-molinski added squad: face Frontend Catalyst Experience Team no-track Used to skip tracking in Swarmia analytics, etc. labels Sep 22, 2025
@damian-molinski damian-molinski moved this from New to 🔖 Ready in Catalyst Sep 22, 2025
@damian-molinski damian-molinski changed the title Feat/unification of notifications 3414 feat(cat-voices): unification of notifications Sep 23, 2025
@damian-molinski damian-molinski moved this from 🔖 Ready to 🏗 In progress in Catalyst Oct 7, 2025
@damian-molinski damian-molinski marked this pull request as ready for review October 8, 2025 13:12
@damian-molinski damian-molinski moved this from 🏗 In progress to 👀 In review in Catalyst Oct 8, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/voices/feat/unification_of_notifications_3414

Copy link
Contributor

@dt-iohk dt-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bstolinski bstolinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit 312a249 into feat/incident_reporting_3158 Oct 9, 2025
45 checks passed
@damian-molinski damian-molinski deleted the feat/unification_of_notifications_3414 branch October 9, 2025 08:39
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-track Used to skip tracking in Swarmia analytics, etc. squad: face Frontend Catalyst Experience Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants