-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): documents campaign isolation #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
damian-molinski
merged 26 commits into
f15/cat-app
from
feat/documents_campaign_isolation_316
Oct 7, 2025
Merged
feat(cat-voices): documents campaign isolation #3462
damian-molinski
merged 26 commits into
f15/cat-app
from
feat/documents_campaign_isolation_316
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LynxLynxx
reviewed
Sep 24, 2025
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposals/proposals_cubit.dart
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Sep 25, 2025
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/campaign/campaign.dart
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Sep 25, 2025
...nternal/catalyst_voices_models/lib/src/campaign/constant/f14_static_campaign_categories.dart
Outdated
Show resolved
Hide resolved
dt-iohk
approved these changes
Sep 25, 2025
Contributor
dt-iohk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/documents_campaign_isolation_316 |
dt-iohk
approved these changes
Sep 25, 2025
Contributor
Author
|
Waiting for |
dt-iohk
reviewed
Oct 7, 2025
catalyst_voices/packages/libs/catalyst_compression/example/ios/.gitignore
Outdated
Show resolved
Hide resolved
dt-iohk
reviewed
Oct 7, 2025
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/money/currency.dart
Outdated
Show resolved
Hide resolved
dt-iohk
added a commit
that referenced
this pull request
Oct 14, 2025
…3492) * chore: remove hardcoded values of f14 and fund14 (#3443) * feat(cat-voices): tracking registration status (#3449) * feat: add account_registration_status to account model + poller * feat: check registration status before refreshing account public profile * checking account indexed status * typos * fix: test * refactor RegistrationStatusPoller so its using Streams * fix: typos * feat(cat-voices): Improvements to import proposals, handling malformed proposals (#3448) * feat: don't import invalid refs and skip malformed proposals * chore: remove unused code * feat: use active campaign observer * chore: fix test * chore: review update * chore: remove not needed emit * chore: return correct new ref * fix: test * chore: change log from info to warning * feat(cat-voices): email already used warning (#3452) * feat: implement registration signal handling for used email * chore: do not report wallet accountChange error to sentry * feat(cat-voices): Multi currency support (#3454) * feat: multi currency support * fix: spelling * fix: revert unwanted changes * refactor: cleanup code * refactor: cleanup tests * refactor: cleanup * feat: update currency formatting * refactor: cleanup formatting * chore(cat-voices): update gateway open api specs (#3461) * chore: update gateway openAPI specs * chore: remove openAPI specs generation from earthly target * fix: failing tests * chore: cleanup earthly targer * chore(cat-voices): cleanup UI (#3469) * fix: document validation takes into account actions and comments too * hard remove voting related content * chore: clean up * fix(cat-voices): disable failing earthly targets (#3482) * feat(cat-voices): multicurrency support and money formatting changes (#3473) * feat: use currency from the schema * feat: allow custom currency codes * refactor: allow description to be nullable * chore: update gateway openAPI specs * chore: remove openAPI specs generation from earthly target * fix: failing tests * feat: add fallback for integer schema * feat: fallback double widget * feat: make debug fallback more visible * feat: allow to only enter decimal text * feat: handle multiple of validation * refactor: cleanup * feat: add support for different formats and currencies related to money in proposals * feat: allow to query currency by iso code * feat: parse document currency format dynamically * feat: convert more raw values into money instances * feat: show allowed money range as money * fix: validation * feat: show multiple of as money * fix: text reverting decimal separators * feat: respect schema's multiple of * docs: document currency format docs * feat: parse money from string * feat: convert money to use BigInts * feat: update decimal input formatter to not exceed safe range of int / double * fix: don't allow decimals in legacy ada format * fix: node id differentiate * fix: nodeId should not consider parent to be a child of itself * feat: format money with code * feat: formatting of different currencies * refactor: code cleanup * fix: spelling * fix: tests * fix: tests * feat: display exact amount for registration fee as wallets do * chore: cleanup * chore: code review changes * refactor: use wildcard function --------- Co-authored-by: Damian Molinski <[email protected]> Co-authored-by: Damian Moliński <[email protected]> * chore(cat-voices): comments category_id (#3468) * include category_id in CommentDocument metadata * chore: spelling * analyzer * feat(cat-voices): documents campaign isolation (#3462) * chore: move const content into fund specific files + fix tests * empty f15 campaign * feat: campaign filters * fix: filter type * feat: workspace multi campaign * fix: viewing older proposals * static all campaigns * fix: more flexible create new proposal dialog * feat: simplify campaign filtering * watch user proposals count for active campaign * campaign change documents clear * fix: analyzer * fix: tests * chore: cleanup * explicit categoryId query type * chore: move active campaign pointers to one file * feat: use category.in filter parameter * fix: failing tests * feat: add ProposalsFilters.forActiveCampaign constructor * final list of all campaigns * chore: refactor creating money logic * fix: gitignore * refactor: amount function * Revert "chore(cat-voices): cleanup UI (#3469)" This reverts commit 8058e1b. * Revert "chore: adding voting page guard (#3437)" This reverts commit 0dd9d2c. * feat(cat-voices): Currency formatting adjustments (#3496) * feat: display money as decimal * feat: display money as decimals * feat: allow only dot as decimal separator * fix: tests * fix: tests * fix: tests * fix: tests * fix: tests * Revert "fix(cat-voices): disable failing earthly targets (#3482)" This reverts commit 2762cd6. * fix: rename method * fix: missing param * chore(cat-voices): update index endpoint parameter (#3501) * chore: update index endpoint parameter * add parameters field to index response dto * fix: index endpoint parameters (#3514) * feat(cat-voices): respect title in agreement confirmation widget (#3500) * refactor(cat-voices): unify range classes (#3513) * refactor: unify ranges * refactor: tests * style: spelling * fix: tests * style: spelling * feat(cat-voices): add placeholder to multi currency formatted amount (#3518) * feat(cat-voices): F15 copy text and ID refs (#3516) * feat: f15 documents refs * feat: categories copy text * feat: category dos and donts * feat: update f15 campaign id * feat: update category ref id in url * chore: clean l10n * chore: raw strings * feat: short description * chore: remove one element * fix: review * feat: support for active fund number in urls (#3526) * feat: change max number of final proposals (#3530) --------- Co-authored-by: Ryszard Schossler <[email protected]> Co-authored-by: Damian Moliński <[email protected]> Co-authored-by: Damian Molinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: proposal
Showing proposals or details of single proposal
no-track
Used to skip tracking in Swarmia analytics, etc.
squad: face
Frontend Catalyst Experience Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares frontend for changing active campaigns
Related Issue(s)
Resolves https://github.com/input-output-hk/catalyst-internal-docs/issues/316
Description of Changes
AppMetaStorage). When changes database documents are removes but templates used by local drafts. This happens insideSyncManager.campaignshown in workspace inside separate section withviewonly option.CampaignFilters. This is not as dynamic as it should be but for now it's enough.campaigndoes not have any categories.f15constructor for campaign.Demo
TODO
Related Pull Requests
v1/document/indexendpointidfield #3446Please confirm the following checks