Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Sep 26, 2025

Description

  • Use structural logging (tracing) instead of println!.
  • Log more details.
  • Replace the PanicHandler trait implementation with a custom middleware to access the request data.

Related Issue(s)

Closes #3234.

Related Pull Requests

input-output-hk/catalyst-ci#464

Notes

Unfortunately there is no straightforward way to access the request body before processing it.

@stanislav-tkach stanislav-tkach self-assigned this Sep 26, 2025
@stanislav-tkach stanislav-tkach moved this from New to 🏗 In progress in Catalyst Sep 26, 2025
@stanislav-tkach stanislav-tkach added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet rust Pull requests that update Rust code squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Oct 2, 2025
@stanislav-tkach stanislav-tkach marked this pull request as ready for review October 8, 2025 22:40
@stanislav-tkach stanislav-tkach removed do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/voices/log-panic-properly

@stanislav-tkach stanislav-tkach moved this from 🏗 In progress to 👀 In review in Catalyst Oct 13, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) October 22, 2025 10:36
@Mr-Leshiy Mr-Leshiy merged commit f6c131e into main Oct 22, 2025
87 of 90 checks passed
@Mr-Leshiy Mr-Leshiy deleted the log-panic-properly branch October 22, 2025 11:27
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge yet PR is not ready to be merged yet rust Pull requests that update Rust code squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

PANIC log inside ServicePanicHandler

3 participants