feat(cat-gateway): Applying latest rbac-registration crate version
#3730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
requested review from
bkioshn,
cong-or,
saibatizoku,
stanislav-tkach and
stevenj
as code owners
Mr-Leshiy
added
squad: gatekeepers
8 tasks
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/latest-rbac-crate |
stanislav-tkach
approved these changes
Nov 20, 2025
Comment on lines
+186
to
+190
| let stake_addresses: HashSet<_> = new_chain | ||
| .stake_addresses() | ||
| .difference(&previous_addresses) | ||
| .cloned() | ||
| .collect(); |
Member
There was a problem hiding this comment.
Note: this is one of the places that we need to update (in the future) to handle removed stake addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applying the latest
rbac-registrationcrate version, with the updated interface and moved all stateful validation logic to the library.Related Issue(s)
Part of #3507
Description of Changes
Provide a clear and concise description of what the pull request changes.
Please confirm the following checks