-
Notifications
You must be signed in to change notification settings - Fork 25
add: ETCM-12351 dolos governed map data source #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ladamesny
wants to merge
27
commits into
master
Choose a base branch
from
ETCM-12351-dolos-governed-map-data-source
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0e92266
some fixes + diff data source
kpinter-iohk a5a545e
fixes
kpinter-iohk 1123111
add block caching
kpinter-iohk 9f129e1
remove diff sources
kpinter-iohk 64ebe1b
fix docstrings
kpinter-iohk 477da44
address comments
kpinter-iohk 1441b3a
better errors
kpinter-iohk edaa6ec
upgrade to dolos rc2
kpinter-iohk 7570d44
formatting
kpinter-iohk 7b29bcd
fix
kpinter-iohk 3e3d7f9
api cleanup
kpinter-iohk 5beac89
fixes
kpinter-iohk 0f28a5a
stake distribution dolos data source
kpinter-iohk a37bb82
wip
kpinter-iohk 31284fb
WIP fix compiler errors
jankun4 a1d7609
Merge remote-tracking branch 'origin/dolos-data-source-bridge-jankun'…
ladamesny b94fdbd
ETCM-12351: Implement governed-map data source
ladamesny 9754ae6
ETCM-12351: clean up for stake distribution
ladamesny ae2bcd7
ETCM-12351: optimize asset utxo dolos query
ladamesny 872256b
tests: fix closing parens and types
ladamesny 90bada8
ETCM-12351: Refactor Dolos data sources: manual asset filtering and i…
ladamesny e3b5957
ETCM-12351: fix dolos data source code
ladamesny 9608e5a
Merge master into ETCM-12351-dolos-governed-map-data-source
ladamesny 8509df2
ETCM-12351: apply option to set dolos to local env
ladamesny bff4f35
ETCM-12351: improve error handling on dolos data sourcce
ladamesny 5933299
Mrge branch 'master' of github.com:input-output-hk/partner-chains int…
ladamesny eda4777
ETCM-12351: rename variable
ladamesny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see 2 datasources coming from dbsync here, StakeDistributionDataSourceImpl and CachedTokenBridgeDataSourceImpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is intentional.
At the beginning of this, we had dbsync based data sources (multiple).
To implement the dolos data sources, I copied the dbsync based data sources, and started replacing them one by one. This is necessary as we can't implement all 5-6 data sources all at once.
There is a transitional period, while the dolos data sources use a mixture of dolos and dbsync. We go through each source in the dolos data sources, and we rewrite the dbsync ones to use dolos.
Note, that all of this is in addition to the dbsync data source, which is kept as is.
Again, in addition to the dbsync data sources we created the dolos ones, which use pieces of the dbsync implementation as stand-in, until they are implemented one by one and replaced. This is needed because there is a lot of code and we don't want to do it all in one PR.