Skip to content

Conversation

tgunnoe
Copy link
Member

@tgunnoe tgunnoe commented Sep 10, 2025

  • replace requirements.txt with pyproject.toml. this brings the e2e-tests python environment in line with modern python projects. It also allows specifying others useful properties like linters and formatters

  • add uv and uv.lock. uv is a modern python package manager that achieves both better speeds and reproducability through locking the exact dependencies required, much like Cargo.lock

  • add these to the nix devshell

  • bump omegaconf to the latest preview, because 2.3.0 included an older version of antlr4-python3-binary that used an older manifest version from the rest of the toolchain

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Copy link
Contributor

@ladamesny ladamesny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* replace requirements.txt with pyproject.toml. this brings the
e2e-tests python environment in line with modern python projects. It
also allows specifying others useful properties like linters and
formatters

* add uv and uv.lock. uv is a modern python package manager that
achieves both better speeds and reproducability through locking the
exact dependencies required, much like Cargo.lock

* add these to the nix devshell

* bump omegaconf to the latest preview, because 2.3.0 included an older
version of antlr4-python3-binary that used an older manifest version
from the rest of the toolchain
Copy link
Contributor

@AmbientTea AmbientTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean to tell me there's a sane build tool for python? 🤨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants