Skip to content

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Oct 9, 2025

What changes are proposed in this pull request?

  • Updated tests to use standalone function skip_if_pkg_not_installed().

Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Optional Reverse Dependency Checks:

Install checked with pak::pak("Genentech/checked") or pak::pak("checked")

# Check dev versions of `cardx`, `gtsummary`, and `tfrmt` which are in the `ddsjoberg` R Universe
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2L, repos = c('https://ddsjoberg.r-universe.dev', 'https://cloud.r-project.org'))"

# Check CRAN reverse dependencies but run tests skipped on CRAN
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

# Check CRAN reverse dependencies in a CRAN-like environment
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = FALSE), checked.check_build_args = '--as-cran'); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

@edelarua edelarua added the sme label Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Unit Tests Summary

  1 files  201 suites   59s ⏱️
201 tests 108 ✅  93 💤 0 ❌
397 runs  283 ✅ 114 💤 0 ❌

Results for commit f55ab55.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
filter_ard_hierarchical 👶 $+0.01$ $+9$ $0$ $0$ $0$
sort_ard_hierarchical 👶 $+0.00$ $+3$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_calculated_row 💔 $0.15$ $+1.20$ add_calculated_row_x_
ard_hierarchical 💔 $5.98$ $+1.34$ ard_hierarchical_works_without_by_variables
ard_stack 💚 $3.22$ $-1.11$ ard_stack_works
ard_stack_hierarchical 💔 $7.22$ $+4.08$ ard_stack_hierarchical_variables_
ard_strata 💔 $0.89$ $+2.23$ ard_strata_works
ard_summary 💚 $12.12$ $-11.23$ ard_summary_works
ard_tabulate 💔 $10.71$ $+1.55$ ard_tabulate_univariate
eval_capture_conditions 💀 $0.05$ $-0.05$ unnamed
filter_ard_hierarchical 👶 $+0.01$ filter_ard_hierarchical_error_messaging_works
filter_ard_hierarchical 👶 $+0.01$ filter_ard_hierarchical_keep_empty_works
filter_ard_hierarchical 👶 $+0.00$ filter_ard_hierarchical_returns_only_summary_rows_when_all_rows_filtered_out
filter_ard_hierarchical 👶 $+0.01$ filter_ard_hierarchical_var_works
filter_ard_hierarchical 👶 $+10.81$ filter_ard_hierarchical_works
filter_ard_hierarchical 👶 $+0.00$ filter_ard_hierarchical_works_when_some_variables_not_included_in_x
filter_ard_hierarchical 👶 $+0.00$ filter_ard_hierarchical_works_with_ard_stack_hierarchical_count_results
filter_ard_hierarchical 👶 $+0.01$ filter_ard_hierarchical_works_with_column_specific_filters
filter_ard_hierarchical 👶 $+0.01$ filter_ard_hierarchical_works_with_non_standard_filters
filter_ard_hierarchical 👶 $+0.00$ filter_ard_hierarchical_works_with_only_one_variable_in_x
filter_ard_hierarchical 👶 $+0.00$ filter_ard_hierarchical_works_with_overall_data
print_ard_conditions 💔 $0.54$ $+1.10$ print_ard_conditions_works
shuffle_ard 💀 $0.04$ $-0.04$ unnamed
shuffle_ard 💚 $3.19$ $-3.14$ shuffle_trim_works
sort_ard_hierarchical 👶 $+0.00$ sort_ard_hierarchical_error_messaging_works
sort_ard_hierarchical 👶 $+0.01$ sort_ard_hierarchical_sort_alphanumeric_works
sort_ard_hierarchical 👶 $+0.01$ sort_ard_hierarchical_sort_descending_works
sort_ard_hierarchical 👶 $+0.00$ sort_ard_hierarchical_sort_works_with_different_sorting_methods_for_each_variable
sort_ard_hierarchical 👶 $+5.44$ sort_ard_hierarchical_works
sort_ard_hierarchical 👶 $+0.00$ sort_ard_hierarchical_works_when_some_variables_not_included_in_x
sort_ard_hierarchical 👶 $+0.00$ sort_ard_hierarchical_works_when_sorting_using_p_instead_of_n
sort_ard_hierarchical 👶 $+0.00$ sort_ard_hierarchical_works_when_there_is_no_overall_row_in_x
sort_ard_hierarchical 👶 $+0.01$ sort_ard_hierarchical_works_with_only_one_variable_in_x
sort_ard_hierarchical 👶 $+0.00$ sort_ard_hierarchical_works_with_overall_data

Results for commit 483c192

♻️ This comment has been updated with latest results.

@edelarua edelarua requested a review from ddsjoberg October 9, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant