Skip to content

Introducing spiderplot/swimlane/waterfall modules #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 142 commits into
base: main
Choose a base branch
from
Draft

Introducing spiderplot/swimlane/waterfall modules #879

wants to merge 142 commits into from

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented May 16, 2025 •
edited
Loading

We need to prepare this PR for main, here is what we need to do:

  • We need to remove unnecessary changes made for early stages of POC. For example teal::ui_brush_filter
  • Make a decision about swimlanely, waterfally, spiderplotly. Only tm_ function should be exported. Comment about moving them to different package is a long term solution, at this moment we can unexport them and not implement show-r-code there (nor a reporter)
  • Unlinke other modules, swimlane/waterfall/spiderplot don't have data_extract but I think it is fine at this moment as we are researching a new way. We can merge these new modules to main and give them space to improve

gogonzo and others added 30 commits November 5, 2024 08:26
@gogonzo
WIP
12f095c
@gogonzo
brush_filter to the module
d348719
@gogonzo
encapsulate brushing functionality
947f151
@gogonzo
fix add filter state
842ba1b
@gogonzo
scatterplot + data_table
a9c9b06
@gogonzo
Merge branch 'main' into spotfire_poc2
bf7b4c4
@gogonzo
WIP
4b987a6 
swimlane POC
@gogonzo
add data_table module to the app
089a06a
@dependabot-preview
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
e0969da
@gogonzo
remove unneeded
c5c744d
@gogonzo
wip
67d4a5c
@gogonzo
quick fix
70d0772
@gogonzo
generalise to enable faceting
2e49a7a
@gogonzo
dummy adam example
4038ba8
@vedhav
feat: add example using the poc data
06bf0a4
@gogonzo
WIP plotly
b9e03c2
@gogonzo
plotly_specs as simple list
32ee42f
@gogonzo
data_table as a brushing table
4321350
@gogonzo
hide table when not brushed
4137aa1
@vedhav
feat: allow the user to pass custom colors and symbols
f1b5d51
@vedhav
feat: reproduce the osprey example
780924c
@vedhav
fix: filter using teal.slice and not during data creation
ea559d3
@gogonzo
rename srv_page_data_table to srv_data_table
21eff43
@vedhav
feat: add refrence lines + filter unwanted data
ea67bd0
@gogonzo
display brushed only
f913acb
@vedhav
push local changes
7d5bc89
@vedhav
export the custom module for deployment
179f145
@vedhav
pass plotly_selected only when it is supported
e18dfc3
@vedhav
feat: use reactable
b5884a2
@vedhav
fix: avoid ns clash of layout
ef85449
@vedhav vedhav force-pushed the poc3@spotfire_poc2 branch from 6ae00d9 to e144900 Compare September 4, 2025 13:33
vedhav and others added 25 commits September 4, 2025 19:07
@vedhav
feat: hide widgets from the module
eb0f489
@vedhav
fix: add pkg prefix for code reproducibility
d660198
only join when there's a record
f9f5bf9
@vedhav
feat: move table outside swimlane
6bcd1f5
@vedhav
feat: apply filter logic for the table
66e980e
@vedhav
Merge remote-tracking branch 'origin/main' into submodules@poc3@spotf…
00eff7d 
…ire_poc2

# Conflicts:
#	R/tm_g_scatterplot.R
#	R/utils.R
@vedhav
Merge remote-tracking branch 'origin/main' into poc3@spotfire_poc2
99fdc87 
# Conflicts:
#	R/tm_g_scatterplot.R
#	R/utils.R
@vedhav
feat: add spaghetti plot module + improve scatter and line plot modules
8c251ed
@vedhav
fix: use package prefix layout is exported in graphics, igraph, and…
636a0cd 
… plotly
@vedhav
typo
f14992e
@vedhav
chore: remove local log
210cb1b
@vedhav
chore: remove legacy subject tooltip triggers
fe7be25
@vedhav
feat: improve bargraph and add double_bargraph module
d647ee1
@vedhav
docs: rename double bargraph to drilldown bargraph + add docs
4b0a1a7
@vedhav
fix: update examples with tooltip_vars usage and fix errors related…
a78a083 
… to it
@vedhav
feat: add the ability to customize tooltips in bargraph
b5d04e2
@vedhav
feat: move the mdr modules outside tmg + split waterfall module
d04c116
@vedhav
feat: split spiderplot + write docs
22abc61
@vedhav
bump version
738cb16
@vedhav
feat: make the modules work with the new composit modules
0e15468
@vedhav
feat: standardize modules - add transformators, improve docs + exam…
b560705 
…ples, param name change, remove `as.name`
@vedhav
chore: fox s[oderplot and write docs for reactable module
e82888f
@vedhav
docs: update docs
c3e3c8b
@vedhav
Merge branch 'submodules@poc3@spotfire_poc2' into poc3@spotfire_poc2
b429647
@vedhav
feat: allow the tooltips to work on dynamic plot ids
7a6b705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gogonzo @vedhav