Fix: Windows support for lore server by using subprocess.run #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi , Could someone with write access please review it? Thanks! |
|
Hi @joseph-instacart, could you please review this PR? It fixes Windows support for running lore server and ensures cross-platform compatibility. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request fixes the issue with running lore server on Windows.
It updates the env.py and main.py to use subprocess.run instead of os.execv for invoking Flask, and ensures the correct path to flask.exe inside the virtual environment is used on Windows.
Why
Previously, running lore server on Windows failed with a FileNotFoundError because os.execv could not locate flask.exe.
This change ensures cross-platform compatibility, allowing Windows users to run the server without errors.