Skip to content

Conversation

instanacd
Copy link
Contributor

Tada!

@instanacd instanacd requested a review from a team as a code owner August 5, 2025 12:52
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirrg001
Copy link
Contributor

kirrg001 commented Aug 5, 2025

Redis test is broken

racing/redis cluster
@instana/collector: require: redis
@instana/collector: When allowRootExitSpan: true is set
@instana/collector: [AgentStubControls] reset 5462
@instana/collector: must trace exit span -- UTC: 2025-08-05T13:16:40.903Z (1754399800903)
@instana/collector: Redis allowRootExitSpan App (version: latest, require: redis, setup type: cluster, pid: 6594): Redis allowRootExitSpan App (version: latest, require: redis, setup type: cluster, pid: 6594):
@instana/collector: Redis allowRootExitSpan App (version: latest, require: redis, setup type: cluster, pid: 6594): Connecting to cluster. (redis://team-nodejs-redis-cluster-tekton.redis.cache.windows.net:6380)
@instana/collector: Redis allowRootExitSpan App (version: latest, require: redis, setup type: cluster, pid: 6594): Redis Cluster Error TypeError: tls socket option is set to true which is mismatch with protocol or the URL redis://team-nodejs-redis-cluster-tekton

const nodes = [
{
url: `redis://${process.env.AZURE_REDIS_CLUSTER}`
url: `rediss://${process.env.AZURE_REDIS_CLUSTER}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new validation has been added in the Redis connection URL for TLS enabled/disabled cases

see: redis/node-redis#2835

@abhilash-sivan abhilash-sivan merged commit a403888 into main Aug 6, 2025
1 check passed
@kirrg001 kirrg001 deleted the currency-bot branch August 6, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants