Skip to content

feat: added support for v25 #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

feat: added support for v25 #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0095b60
feat: added support for v25
aryamohanan Oct 17, 2025
3ad7778
chore: added comment
aryamohanan Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion native-dep-packs/rebuild-precompiled-addons.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,18 @@ set -eo pipefail

cd `dirname $BASH_SOURCE`

# We intentionally skip defining Node.js v25 because:
# - Node.js 25 is a non-LTS release with a short support window.
# - Excluding v25 helps reduce the overall package size.
# - Most users remain on stable LTS versions such as 22,24, etc.
declare -A ABI_VERSIONS=( \
["108"]="18.18" \
["115"]="20.19" \
["120"]="21.2" \
["127"]="22.0" \
["131"]="23.0" \
["137"]="24.0"
["137"]="24.0"
# ["141"]="25.0" # Non-LTS (skipped intentionally)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended https://jsw.ibm.com/browse/INSTA-786 to drop all non LTS prebuilds in next major.

)


Expand Down
7 changes: 6 additions & 1 deletion packages/collector/test/nativeModuleRetry/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ const tmpFolder = path.join(os.tmpdir(), 'native-module-retry', process.pid.toSt

// NOTE: we skip this test on the prerelease pipeline because
// we add prereleases when the official Node.js release happens.
const mochaSuiteFn = semver.prerelease(process.versions.node) ? describe.skip : describe;
// This test runs only on stable, even-numbered Node.js versions
const majorVersion = parseInt(process.versions.node.split('.')[0], 10);
const isOddVersion = majorVersion % 2 !== 0;
const isPrerelease = Boolean(semver.prerelease(process.versions.node));

const mochaSuiteFn = isOddVersion || isPrerelease ? describe.skip : describe;

// Test suite for verifying the fallback mechanism for loading native add-ons.
mochaSuiteFn('retry loading native addons', function () {
Expand Down
5 changes: 4 additions & 1 deletion packages/collector/test/tracing/databases/pg_native/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
'use strict';

const expect = require('chai').expect;
const semver = require('semver');
const constants = require('@instana/core').tracing.constants;
const supportedVersion = require('@instana/core').tracing.supportedVersion;
const config = require('../../../../../core/test/config');
Expand All @@ -19,7 +20,9 @@ const {
const ProcessControls = require('../../../test_util/ProcessControls');
const globalAgent = require('../../../globalAgent');

const mochaSuiteFn = supportedVersion(process.versions.node) ? describe : describe.skip;
// pg-native is not supported on Node.js 25
const mochaSuiteFn =
supportedVersion(process.versions.node) && semver.lt(process.versions.node, '25.0.0') ? describe : describe.skip;

mochaSuiteFn('tracing/pg-native', function () {
this.timeout(config.getTestTimeout());
Expand Down