Fix NPE on server startup when transactions table is empty #2142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When starting the server against a fresh, empty database, the application enters a crash loop.
The
instant.db.model.transaction/initfunction queriesMAX(id)from thetransactionstable. On a fresh install, this table is empty, so Postgres returnsNULL. The code attempts to cast thisnilresult to a primitivelongvia(long ...), resulting in aNullPointerException.Because of this the server crashes and instantdb doesn't work at all.
Context
This appears to be a regression introduced in #2107. That PR added logic to populate the transaction ID on initialization but does not handle the case where the database is completely empty (returning
nil).Solution
Updated
max-tx-idinsrc/instant/db/model/transaction.cljto handle thenilcase by defaulting to0.Steps to Reproduce
(Assumes you are starting with a fresh install and there is not yet any database)
git clone https://github.com/instantdb/instant.gitinstant/server/.make docker-compose.init.finish.tx-modelphase.