Optimize compile time

[vargaat]

What's new?

• Refactored large flatMap chains that caused very slow type checking. One of these checks took 8 secs on my M1. No behavior changes.
• I made 3 before-after measurements and on average the compile was 8 seconds faster (from 146.3 to 138.4) after the refactoring.

[ignore-commit-lint]

[inst-danger]

Builds

No apps were built for this pull request.

To trigger app builds, include a line starting with builds: followed by app names (Student, Teacher, Parent, or All) in your pull request's message.

Commit: Another refactor. (3f8dfe5)
Built At: Oct 06 14:56 CEST (10/06 06:56 AM MDT)

[inst-danger]

	Warnings
⚠️	One or more files are below the minimum test coverage 50%
⚠️	The total test coverage is below the minimum 90%

Coverage	New %	Master %	Delta
Canvas iOS	79.09%	79.09%	-0%
Core/Core/Common/Extensions/Combine/SubjectExtensions.swift	0%	0%	0%
Core/Core/Features/Planner/Model/API/APICalendarEventSubAssignment.swift	0%	0%	0%
Core/Core/Features/Enrollments/GetEnrollments.swift	48.81%	48.81%	0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/LTIQuiz/OnAppear.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/View/EmbeddedWebPage/HEmbeddedWebPageContainerViewModel.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/LTIQuiz/DidSubmitQuiz.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Inbox/Attachment/AttachmentViewModel.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Notebook/Common/Data/UpdateRedwoodNote.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/Data/SubmissionProperties.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Data/LearningObjectType.swift	0%	0%	0%

Generated by 🚫 dangerJS against 3f8dfe5

[petkybenedek]

QA +1