Skip to content

wip: mobile topnav poc #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: master
Choose a base branch
from
Draft

wip: mobile topnav poc #1644

wants to merge 53 commits into from

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Aug 22, 2024

No description provided.

@balzss balzss self-assigned this Aug 22, 2024
@balzss balzss force-pushed the feat/mobile-topnav-poc branch from 5b000f0 to b93c859 Compare August 25, 2024 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 25, 2024 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://instructure.design/pr-preview/pr-1644/

Built to branch gh-pages at 2025-03-21 09:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@balzss balzss assigned joyenjoyer and unassigned balzss Oct 3, 2024
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from 86c1810 to d4418f5 Compare November 17, 2024 15:09
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from 2583ff1 to 5cbbc82 Compare December 2, 2024 13:05
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from 16ef5db to 0b7d9ed Compare December 13, 2024 15:56
@matyasf matyasf requested review from aaronshaf and cvkline December 13, 2024 16:26
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from 282caa2 to a4ccc61 Compare March 13, 2025 15:56
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from 7d1f2b6 to 8d776ed Compare April 10, 2025 13:16
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from f6bb16d to c2c8a4d Compare June 24, 2025 14:08
balzss and others added 17 commits June 25, 2025 14:11
@balzss @joyenjoyer
WIP(ui-top-nav-bar): wip
25dcee3
@balzss @joyenjoyer
WIP(ui-top-nav-bar): wip
5bafd81
@joyenjoyer
WIP(ui-top-nav-bar): add item and itemlist
0cd034c
@joyenjoyer
WIP(ui-top-nav-bar): some refactor
901dd8b
@joyenjoyer
WIP(ui-top-nav-bar): add lightMode
793f46d
@joyenjoyer
WIP: add WrapperComponent to test resizing
aeb903f
@joyenjoyer
WIP(ui-top-nav-bar): add desktop topnav
d54fd13
@joyenjoyer
WIP(ui-top-nav-bar): some refactoring
a5a85a8
@joyenjoyer
WIP(ui-top-nav-bar): inject lightMode
7a1a571
@joyenjoyer
WIP(ui-top-nav-bar): clean DesktopTopNav
070b941
@joyenjoyer
WIP(ui-top-nav-bar): api rework
65449b9
@joyenjoyer
WIP(ui-top-nav-bar): finetuning after grooming meeting
df12838
@joyenjoyer
WIP(ui-top-nav-bar): add more changes after review
2a08610
@joyenjoyer
WIP(ui-top-nav-bar): fix build errors
e7798c3
@joyenjoyer
WIP(ui-top-nav-bar): clear index.tsx and create a basic menu structure
c8934d0
@joyenjoyer
WIP: add smart menu navigation
5d741e7
@joyenjoyer
WIP: refine menu handling
079cd9d
joyenjoyer and others added 24 commits June 25, 2025 14:12
@joyenjoyer
WIP(ui-top-nav-bar): improve types
07c8a1b
@joyenjoyer
WIP(shared-types,ui-drilldown,ui-top-nav-bar): add lti colors
0423fb3
@joyenjoyer
WIP(emotion,ui-drilldown,ui-top-nav-bar): add sidenav
11889e5
@joyenjoyer
feat(ui-top-nav-bar): add buttons prop
66ad630
@joyenjoyer
feat(ui-top-nav-bar,ui-drilldown): adjust types
9545953
@joyenjoyer
feat(ui-themes,shared-types): add new colors
338d4a7 
INSTUI-4471
@joyenjoyer
feat(ui-top-nav-bar): add stuff
84efd69
@joyenjoyer
feat(ui-top-nav-bar): add tray
f7a31e6
@joyenjoyer
feat: replace href to onclick
9ed570a
@joyenjoyer
chore(ui-top-nav-bar): integrate useStyle into SubNav to aid testing
cb9ce7e
@joyenjoyer
chore(ui-top-nav-bar): finetune subnav
5d32308
@joyenjoyer
chore(ui-top-nav-bar): add stuff
9ed3eec
@joyenjoyer
chore(ui-top-nav-bar): add LTI
617a43e
@joyenjoyer
refactor(ui-top-nav-bar,shared-types): add useStyle
a5ffe3d
@joyenjoyer
refactor(ui-top-nav-bar): fix svg
5ff13c9
@joyenjoyer
refactor(ui-top-nav-bar): fix style stuff
75d54c8
@joyenjoyer
chore(ui-top-nav-bar): add DeepPartial theme
a994015
@joyenjoyer
refactor(ui-top-nav-bar): asddsads
e3c410f
@joyenjoyer
chore(ui-top-nav-bar,ui-drilldown,emotion): kk
6dfddba
@joyenjoyer
refactor(ui-top-nav-bar): add submenu pages
38a1538
@joyenjoyer
feat(ui-top-nav-bar,shared-types): style fix
38f2e32
@joyenjoyer
refactor(ui-top-nav-bar): change api
01b66ab
@git-nandor @joyenjoyer
test(ui-top-nav-bar): add tests
b236c78
@joyenjoyer
test: playground for testing
a9760d9
@joyenjoyer joyenjoyer force-pushed the feat/mobile-topnav-poc branch from cc34778 to a9760d9 Compare June 27, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronshaf aaronshaf Awaiting requested review from aaronshaf

@cvkline cvkline Awaiting requested review from cvkline

At least 2 approving reviews are required to merge this pull request.

Assignees

@joyenjoyer joyenjoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balzss @joyenjoyer @git-nandor