Skip to content

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Sep 12, 2025

… correctly in Firefox

INSTUI-4330

ISSUE:

NVDA was not properly announcing options within Drilldown.Group components in Firefox. The issues were:

  • all options were announced simultaneously on focus
  • the checked state of the selected option was not read
  • options were not navigable with keyboard

TEST PLAN:

  • with Firefox (!) and NVDA, inspect the 'Single-select Group' example
  • go through the option, they should be navigable with keyboard and the checked option should be announced as checked and the options should not be announced
  • other examples with a Drilldown.Group should behave the same like above (e.g.: 'Video Settings' example, 'Option Groups' example)
  • on Mac with Chrome, Firefox and Safari, examples with a Drilldown.Group should have a role='group' instead of 'menu'
  • because I could not define a screenreader-specific condition, the role is also changed to 'menu' in Firefox+JAWS. This results in the group titles not always being read in Firefox+JAWS, but it is still a less severe issue than the one with Firefox+NVDA.

@ToMESSKa ToMESSKa self-assigned this Sep 12, 2025
@ToMESSKa ToMESSKa changed the title fix(ui-utils,ui-drilldown): make NDVA read options in Drilldown.Group… fix(ui-utils,ui-drilldown): make NVDA read options in Drilldown.Group… Sep 12, 2025
@github-actions
Copy link

github-actions bot commented Sep 12, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-01 08:52 UTC

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks (sounds) good!

@ToMESSKa ToMESSKa merged commit 994f158 into master Oct 1, 2025
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4330-drilldown-examples-that-use-role-group-should-be-updated-to-role-menu branch October 1, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants