Skip to content

fix(ui-color-picker): prevent selection outside of ColorMixer when dr… #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui-color-picker): prevent selection outside of ColorMixer when dr… #2145

wants to merge 1 commit into from

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Sep 16, 2025 •
edited
Loading

…agging the indicator

INSTUI-4698

ISSUE:

TEST PLAN:

  • open the first example in ColorMixer
  • try and drag all three white indicator buttons to the edge of the palette then make the mouse leave the palette while holding the mouse down
  • nearby content or text should not get selected
  • ColorMixer should get focused when clicked on
  • ColorMixer should remain keyboard accessible (should be tabable, the indicator should be navigable with keyboard)
  • check the first two examples in ColorPicker, other page content should not get selected when indicators are getting dragged in the ColorMixer
  • the two examples should be keyboard accessible

@ToMESSKa ToMESSKa force-pushed the INSTUI-4698-dragging-color-mixers-slider-selects-other-page-content branch from 6cf6377 to a2645a7 Compare September 16, 2025 14:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://instructure.design/pr-preview/pr-2145/

Built to branch gh-pages at 2025-09-16 14:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4698-dragging-color-mixers-slider-selects-other-page-content branch from a2645a7 to 7b27207 Compare September 16, 2025 14:44
@ToMESSKa ToMESSKa self-assigned this Sep 16, 2025
@ToMESSKa ToMESSKa requested review from HerrTopi and removed request for joyenjoyer September 25, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@HerrTopi HerrTopi Awaiting requested review from HerrTopi

At least 2 approving reviews are required to merge this pull request.

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToMESSKa @matyasf