Skip to content

feat(ui-alerts): expand Alert's liveRegion to accept direct DOM element #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(ui-alerts): expand Alert's liveRegion to accept direct DOM element #2147

wants to merge 1 commit into from

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Sep 17, 2025 •
edited
Loading

INSTUI-4454

ISSUE:

  • Alert's liveRegion only accept a function, not a direct DOM element

TEST PLAN:

  • in the third example in Alert, pass a direct element as liveRegion e.g.: liveRegion={document.getElementById('flash-messages')} instead of a function
  • screenreader should announce the alert

@ToMESSKa ToMESSKa self-assigned this Sep 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://instructure.design/pr-preview/pr-2147/

Built to branch gh-pages at 2025-09-17 15:01 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4454-use-better-type-for-alerts-live-region branch from 235fe57 to 36f5449 Compare September 17, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@joyenjoyer joyenjoyer Awaiting requested review from joyenjoyer

At least 2 approving reviews are required to merge this pull request.

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToMESSKa @matyasf