Skip to content

Fix Repository Custom Properties Refresh #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Repository Custom Properties Refresh #2691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion github/resource_github_repository_custom_property.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ func resourceGithubRepositoryCustomPropertyRead(d *schema.ResourceData, meta int
return err
}

if wantedCustomPropertyValue == nil {
d.SetId("")
return nil
}

d.SetId(buildThreePartID(owner, repoName, propertyName))
d.Set("repository", repoName)
d.Set("property_name", propertyName)
Expand Down Expand Up @@ -154,7 +159,7 @@ func readRepositoryCustomPropertyValue(ctx context.Context, client *github.Clien
}

if wantedCustomProperty == nil {
return nil, fmt.Errorf("could not find a custom property with name: %s", propertyName)
return nil, nil
}

wantedPropertyValue, err := parseRepositoryCustomPropertyValueToStringSlice(wantedCustomProperty)
Expand Down
Loading