fix(resource/github_actions_environment_variable): handle existing va… #2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables on create The `github_actions_environment_variable` resource would fail with a 409 Conflict error if the environment variable already existed in GitHub but not in the Terraform state. This could happen if the variable was created manually in the GitHub UI. This commit changes the create function to handle this conflict. It now attempts to update the variable if it already exists, effectively performing an "upsert" operation. This makes the resource more resilient and avoids unexpected errors when managing existing resources. Fixes integrations#2328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(actions): Handle existing environment variables on create
Description
This PR fixes an issue with the
github_actions_environment_variableresource where it would fail with a409 Conflicterror if the environment variable already existed in GitHub but not in the Terraform state. This typically occurs when a variable is created manually via the GitHub UI and then later managed by Terraform.The
Createfunction for the resource has been updated to handle this scenario gracefully. It now attempts toUpdatethe variable if it already exists, effectively performing an "upsert" operation. This makes the resource more robust and prevents unexpected errors.Fixes #2328
How to test
An acceptance test has been added to cover this specific scenario. You can run the test with the following command:
TF_ACC=1 go test -v ./github -run ^TestAccGithubActionsEnvironmentVariable_alreadyExists$This test: