Add support for 'exempt' github_repository_ruleset bypass_mode #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe don't replace the |
|
Ahh, thanks for catching that @krische. My IDE auto-formatted the markdown upon save and I didn't catch it 😅 |
v1v
reviewed
Oct 8, 2025
| Required: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"always", "pull_request"}, false), | ||
| ValidateFunc: validation.StringInSlice([]string{"always", "pull_request", "exempt"}, false), | ||
| Description: "When the specified actor can bypass the ruleset. pull_request means that an actor can only bypass rules on pull requests. Can be one of: `always`, `pull_request`.", |
There was a problem hiding this comment.
I think the description needs to be updated too:
Suggested change
| Description: "When the specified actor can bypass the ruleset. pull_request means that an actor can only bypass rules on pull requests. Can be one of: `always`, `pull_request`.", | |
| Description: "When the specified actor can bypass the ruleset. pull_request means that an actor can only bypass rules on pull requests. Can be one of: `always`, `pull_request`, `exempt`.", |
| Required: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"always", "pull_request"}, false), | ||
| ValidateFunc: validation.StringInSlice([]string{"always", "pull_request", "exempt"}, false), | ||
| Description: "When the specified actor can bypass the ruleset. pull_request means that an actor can only bypass rules on pull requests. Can be one of: `always`, `pull_request`.", |
There was a problem hiding this comment.
I think the description needs to be updated too:
Suggested change
| Description: "When the specified actor can bypass the ruleset. pull_request means that an actor can only bypass rules on pull requests. Can be one of: `always`, `pull_request`.", | |
| Description: "When the specified actor can bypass the ruleset. pull_request means that an actor can only bypass rules on pull requests. Can be one of: `always`, `pull_request`, `exempt`.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2755
I'm not familiar with terraform provider development, so I'm not sure if there's anything else I'm missing, but this looked right to me.
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?