Skip to content

fix: osv data source memory consumption #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

fix: osv data source memory consumption #4956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1a2eff3
feat: added new OSV data source class initial implementation
fil1n Mar 12, 2025
c146c45
feat: added file fetching to OSV datasource
fil1n Mar 13, 2025
0b5a52f
feat: added zip extraction for osv
fil1n Mar 13, 2025
f076096
feat: added data formatting method
fil1n Mar 13, 2025
ec2cad4
chore: added google-cloud-storage to requirements
fil1n Mar 13, 2025
803ce56
feat: replaced old OSV source
fil1n Mar 13, 2025
f9e7b95
feat: minor logging and naming improvements
fil1n Mar 13, 2025
d3a1e92
feat: decompressed small files in memory
fil1n Mar 13, 2025
a240bda
feat: minor code improvements
fil1n Mar 17, 2025
3b403b4
test: adapted tests for new data source
fil1n Mar 18, 2025
7aeca1b
refactor: moved json parsing to separate function
fil1n Mar 18, 2025
77dd8e5
docs: added some comments
fil1n Mar 18, 2025
38fd375
refactor: useless code line removed
fil1n Mar 18, 2025
8fc8aa7
docs: docstring changed
fil1n Mar 18, 2025
3f29e1b
fix: ignored None values
fil1n Mar 19, 2025
2f9b2a0
Merge branch 'main' into new_osv_datasource
fil1n Mar 19, 2025
28eb7ac
chore: updated requirements
fil1n Mar 19, 2025
79a3d81
Revert "chore: updated requirements"
fil1n Mar 19, 2025
256009e
chore: updated
fil1n Mar 19, 2025
e43d745
refactor: removed unused field
fil1n Mar 23, 2025
1c27571
Merge branch 'main' into new_osv_datasource
fil1n Mar 23, 2025
eedfe4f
Merge branch 'main' into new_osv_datasource
fil1n Jul 21, 2025
afac134
fix: DEFAULT_LOCATION import
fil1n Jul 21, 2025
e958858
Merge branch 'main' into new_osv_datasource
ffontaine Aug 14, 2025
30028b3
refactor: removed old osv data source
fil1n Aug 29, 2025
2a69c73
fix: added httplib2 to requirements
fil1n Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cve_bin_tool/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ def main(argv=None):
enabled_sources = []

if "OSV" not in disabled_sources:
source_osv = osv_source.OSV_Source(incremental_update=incremental_db_update)
source_osv = osv_source.OSVDataSource()
Copy link
Contributor

@alex-ter alex-ter Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) The new name does not follow the format all the other source classes use. I guess this is an artifact of it initially existing alongside the original implementation, but now that there's only one, I see no reason for deviating from the convention.

enabled_sources.append(source_osv)

if "GAD" not in disabled_sources:
Expand Down
2 changes: 1 addition & 1 deletion cve_bin_tool/cvedb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class CVEDB:
SOURCES = [
curl_source.Curl_Source,
epss_source.Epss_Source,
osv_source.OSV_Source,
osv_source.OSVDataSource,
gad_source.GAD_Source,
purl2cpe_source.PURL2CPE_Source,
nvd_source.NVD_Source, # last to avoid data overwrites
Expand Down
Loading
Loading