[SYCL][NFC] generate_sycl_abi_symbols CMake target #19362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently developers have to manually run `abi_check.py`, but this is error prone for multiple reasons. This patch adds a custom CMake target `generate_sycl_abi_symbols` that runs the script with the correct arguments and dependencies. `abi_check.py` has also been updated to take `--llvm-bin-path` as an argument to replace having to specify `LLVM_BIN_PATH`. The old functionality is still supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently developers have to manually run
abi_check.py, but this is error prone for multiple reasons.This patch adds a custom CMake target
generate_sycl_abi_symbolsthat runs the script with the correct arguments and dependencies.abi_check.pyhas also been updated to take--llvm-bin-pathas an argument to replace having to specifyLLVM_BIN_PATH. The old functionality is still supported.