[UR][HIP] Refactor reference counting in UR HIP adapter using new ur::RefCount class #19387
+87
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
cb97307 to
bdf41ce
Compare
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
bdf41ce to
6de79b3
Compare
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
6de79b3 to
d2740e6
Compare
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
d2740e6 to
3cea679
Compare
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
3cea679 to
2beb1e2
Compare
martygrant
requested a deployment
to
WindowsCILock
GitHub Actions
In progress
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
2beb1e2 to
11bee99
Compare
martygrant
force-pushed
the
refCountRefactorHIP
branch
from
11bee99 to
d720bc6
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
The CUDA and HIP adapters are very similar and covered by the same reviewer team, it would be totally fine to migrate them together in one PR. If you have the CUDA changes already I'd suggest just adding them here, but otherwise it's fine. |
reble
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #18644
Most UR adapters had their own reference counting of some sort. This adds a new RefCount class and refactors adapter code so all adapters can share the same code for reference counting. This PR handles HIP.
I have kept the pre-existing reference counting members inside stream_queue.hpp, temporarily renaming it as RefCountOld as the CUDA adapter also uses this and want to only change one adapter per PR. I will change this in the final PR for this piece of work.