[libclc][test] Really run libspirv tests on all targets #19395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way `add_lit_testsuite` works, the `check-all` target was not running the libspirv (binding) tests on all targets, instead it was running it on the last target multiple times in parallel. Besides losing the coverage for other targets, this also caused sporadic failures due to tests overwriting each other. intel#17902 was an attempt to fix this, and it works for running all of the `check-libclc-spirv-*` cmake targets in parallel, but it does not work for the `check-all` target, which is what we use in the CI. This patch fixes the issue by making a different `lit` test suite for each target. See the comment in `libclc/test/CMakeLists.txt` for more details.
|
Thanks for fixing this! A bit of context is that I've been trying for over a year (on and off) to get libclc tested upstream. If/when that happens will likely be a completely different approach to testing and all of our downstream testing will need completely reworked, which is partly why I haven't given downstream testing much attention since taking it over. I'll take a closer look at this PR on Monday. But with the background that this will (hopefully) be a temporary testing solution anyway, as long as something works then it's fine by me! |
frasercrmck
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way
add_lit_testsuiteworks, thecheck-alltarget was not running the libspirv (binding) tests on all targets, instead it was running it on the last target multiple times in parallel. Besides losing the coverage for other targets, this also caused sporadic failures due to tests overwriting each other. #17902 was an attempt to fix this, and it works for running all of thecheck-libclc-spirv-*cmake targets in parallel, but it does not work for thecheck-alltarget, which is what we use in the CI.This patch fixes the issue by making a different
littest suite for each target. See the comment inlibclc/test/CMakeLists.txtfor more details.