[SYCL] Kernel submit wrapper functions for unit tests #19884
+62
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Comment on lines
+1
to
+7
| //==-- CommandSubmitWrappers.hpp --- -----==// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// |
There was a problem hiding this comment.
Suggested change
| //==-- CommandSubmitWrappers.hpp --- -----==// | |
| // | |
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | |
| // See https://llvm.org/LICENSE.txt for license information. | |
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |
| // | |
| //===----------------------------------------------------------------------===// | |
| //==-- CommandSubmitWrappers.hpp -----------------------------------------==// | |
| // | |
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | |
| // See https://llvm.org/LICENSE.txt for license information. | |
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |
| // | |
| //===----------------------------------------------------------------------===// |
| #include <sycl/event.hpp> | ||
| #include <sycl/handler.hpp> | ||
|
|
||
| using namespace sycl; |
There was a problem hiding this comment.
I'd personally avoid using using namespace sycl here as it will pollute the global namespace of every test that includes this header file.
| #include <sycl/handler.hpp> | ||
|
|
||
| using namespace sycl; | ||
|
|
There was a problem hiding this comment.
Can we please add a comment here about why we need this wrapper?
| } | ||
|
|
||
| template <typename KernelName, typename KernelType> | ||
| event single_task_wrapper(bool ShortcutSubmitFunction, queue &Q, event DepEvent, |
There was a problem hiding this comment.
Suggested change
| event single_task_wrapper(bool ShortcutSubmitFunction, queue &Q, event DepEvent, | |
| event single_task_wrapper(bool ShortcutSubmitFunction, queue &Q, event &DepEvent, |
| cgh.single_task<KernelName>(KernelFunc); | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| // Check that isolated kernels (i.e. those that don't modify the graph) | ||
| // are handled properly during filtering. | ||
| sycl::unittest::UrMock<> Mock; | ||
| sycl::platform Plt = sycl::platform(); | ||
| bool ShortcutSubmitFunction = GetParam(); |
There was a problem hiding this comment.
NIT: I'd have used UseShortcutFunction (or something similar) variable name instead of ShortcutSubmitFunction.
| @@ -190,3 +189,6 @@ TEST_F(SchedulerTest, InOrderQueueNoSchedulerPath) { | |||
| } | |||
|
|
|||
| } // anonymous namespace | |||
|
|
|||
| INSTANTIATE_TEST_SUITE_P(SchedulerTestInstance, SchedulerTest, | |||
| testing::Values(true, false)); | |||
There was a problem hiding this comment.
Suggested change
| testing::Values(true, false)); | |
| testing::Values(true, false) /*Whether to use shortcut submission function or not?*/); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new kernel submit wrapper functions allow to select the submission function type between a standard handler-based function and queue shortcut function. This change allows to increase the test coverage and allows for testing no-handler submission path using existing unit tests.