[SYCL][CMake] Simplify emhash fetch code #19894
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream added a CMake install target, so now we can rely on that when using a system installed version, and we can create an interface target to emulate the real one when using FetchContent.
The upstream CMake install target installs all files directly in the given prefix folder, so with
CMAKE_PREFIX_PATH=/usrit will installhash_table8.hppdirectly to/usr, not in anemhashsubfolder.Since it seems that's how upstream wants this packaged, update our includes to remove the fake
emhashsubdirectory.Issue: #19635