Skip to content

Migrate RegisterFile to use a LogicArray and standard reset #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate RegisterFile to use a LogicArray and standard reset #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 25 additions & 28 deletions lib/src/memory/register_file.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,39 +44,36 @@ class RegisterFile extends Memory with ResettableEntries {
_buildLogic();
}

//TODO: test getData
/// A testbench hook to access data at a given address.
LogicValue? getData(LogicValue addr) => _storageBank[addr.toInt()].value;

/// Flop-based storage of all memory.
late final List<Logic> _storageBank;
late final LogicArray _storageBank =
LogicArray([numEntries], dataWidth, name: 'storageBank');

void _buildLogic() {
// create local storage bank
_storageBank = List<Logic>.generate(
numEntries, (i) => Logic(name: 'storageBank_$i', width: dataWidth));

Sequential(clk, [
If(reset, then: [
..._storageBank.mapIndexed((i, e) => e < _resetValues[i])
], orElse: [
for (var entry = 0; entry < numEntries; entry++)
...wrPorts.map((wrPort) =>
// set storage bank if write enable and pointer matches
If(wrPort.en & wrPort.addr.eq(entry), then: [
_storageBank[entry] <
(wrPort is MaskedDataPortInterface
? [
for (var index = 0; index < dataWidth ~/ 8; index++)
mux(
wrPort.mask[index],
wrPort.data
.getRange(index * 8, (index + 1) * 8),
_storageBank[entry]
.getRange(index * 8, (index + 1) * 8))
].rswizzle()
: wrPort.data),
])),
]),
Sequential(clk, reset: reset, resetValues: {
for (var i = 0; i < numEntries; i++)
_storageBank.elements[i]: _resetValues[i]
}, [
for (var entry = 0; entry < numEntries; entry++)
...wrPorts.map((wrPort) =>
// set storage bank if write enable and pointer matches
If(wrPort.en & wrPort.addr.eq(entry), then: [
_storageBank.elements[entry] <
(wrPort is MaskedDataPortInterface
? [
for (var index = 0; index < dataWidth ~/ 8; index++)
mux(
wrPort.mask[index],
wrPort.data
.getRange(index * 8, (index + 1) * 8),
_storageBank.elements[entry]
.getRange(index * 8, (index + 1) * 8))
].rswizzle()
: wrPort.data),
])),
]);

Combinational([
Expand All @@ -86,7 +83,7 @@ class RegisterFile extends Memory with ResettableEntries {
Case(rdPort.addr, [
for (var entry = 0; entry < numEntries; entry++)
CaseItem(Const(LogicValue.ofInt(entry, addrWidth)),
[rdPort.data < _storageBank[entry]])
[rdPort.data < _storageBank.elements[entry]])
], defaultItem: [
rdPort.data < Const(0, width: dataWidth)
])
Expand Down
Loading