-
Notifications
You must be signed in to change notification settings - Fork 52
add vectorization path on maxpool backward channel last #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chunhuanMeng
wants to merge
8
commits into
main
Choose a base branch
from
meng_opt_max_pool_backward
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a vectorization path for maxpool backward operations in channel-last memory layout to improve performance. The change introduces a new templated kernel implementation that processes multiple elements simultaneously using vector operations.
- Refactors existing backward kernel to accumulate gradients locally before writing
- Adds new vectorized kernel implementation for channel-last memory layout
- Includes vectorization logic (currently commented out) with macro for launching vectorized kernels
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
liangan1
approved these changes
Aug 19, 2025
jianyizh
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #1861
on PVC, 101,628 Scoreboard stalls decrease to 75,976. Significantly fewer instruction fetch and distance stalls, enabling higher effective bandwidth to HBM.