-
Notifications
You must be signed in to change notification settings - Fork 61
Roll back to original usage of sycl::get_kernel_bundle #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR rolls back the usage of sycl::get_kernel_bundle to its original device-agnostic form, removing a workaround that was needed for oneAPI versions prior to 2025.2. The change eliminates device-specific kernel bundle creation and the associated comments explaining the workaround.
- Reverts
sycl::get_kernel_bundlecall to use only kernel ID instead of both device and kernel ID - Removes workaround comments that referenced a specific GitHub issue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@CuiYifeng This patch is causing regression for some of the E2E model for both single- and multi-rank distributed training. Does the new DLE version require removing the device id from the kernel bundle? Do you have any documentation? |
@newtdms The device id of |
|
@CuiYifeng Yes, I am using LKG 2025.2.1, used by the PT upstream nightly. |
This reverts commit 83a1555.
To solve #1121.
The original usage of
sycl::get_kernel_bundleshould not be device-specific. Since the fixing has landed on oneAPI 2025.2, kernel bundle is now created using only the kernel ID (kid) instead of both device and kernel ID, removing the workaround for device-specific kernel builds and associated comments.