framereader: fix read_frame_I010 #705
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
hi @uartie @FocusLuo @Hangjie22Coder , please take review |
uartie
suggested changes
Mar 31, 2025
Contributor
uartie
left a comment
uartie
left a comment
There was a problem hiding this comment.
This change doesn't do anything new/different.
Contributor
|
Please create a unit test, too, in test/self/formats.py |
Contributor
|
... and please add more details to the actual git commit message body. |
As libva defined: ``` /** I010: three-plane 10-bit YUV 4:2:0. * * Each sample is a two-byte little-endian value with the top six bits ignored. * The three planes contain Y, V and U respectively. */ ``` Signed-off-by: jianfeng.zheng <[email protected]>
gitgjogh
force-pushed
the
fix_read_frame_I010
branch
from
61ad470 to
51fbc15
Compare
Signed-off-by: jianfeng.zheng <[email protected]>
Author
I don't quite sure how you generate the assets. Never mind. I write a small tools to convert P010 to I010. Seem test/self/formats.py just make read test without content check, I made inverse I010 to P010 convertion to assert right. |
uartie
approved these changes
Apr 18, 2025
Contributor
|
@Bin-CI please fix CI or delegate to someone who can. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as va.h defined
/** I010: three-plane 10-bit YUV 4:2:0.
*
*/
#define VA_FOURCC_I010 0x30313049