Skip to content

Improve error messages #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error messages #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/schematic/schematic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ func main() {
var s schematic.Schema
d := json.NewDecoder(i)
if err := d.Decode(&s); err != nil {
log.Fatal(err)
log.Fatal(fmt.Errorf("Error decoding schema JSON: %w", err))
}

code, err := s.Generate()
if err != nil {
fmt.Fprintf(os.Stderr, "%s\n", code)
log.Fatal(err)
log.Fatal(fmt.Errorf("Error generating Go code (output above): %w", err))
}

fmt.Fprintln(o, string(code))
Expand Down
4 changes: 2 additions & 2 deletions gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (s *Schema) Generate() ([]byte, error) {
}

if !context.Definition.AreTitleLinksUnique() {
return nil, fmt.Errorf("duplicate titles detected for %s", context.Name)
return nil, fmt.Errorf("Duplicate %s.links.title detected in the schema. Links must have distinct titles.", context.Name)
}

templates.ExecuteTemplate(&buf, "struct.tmpl", context)
Expand All @@ -88,7 +88,7 @@ func (s *Schema) Generate() ([]byte, error) {
// Format sources
clean, err := format.Source(bytes)
if err != nil {
return buf.Bytes(), err
return bytes, fmt.Errorf("Error formatting Go source: %w", err)
}
return clean, nil
}
Expand Down