feat(docs): add node snippets locally #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpayments-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mkurapov
commented
Sep 22, 2025
Comment on lines
+11
to
+22
| const gitRoot = execSync('git rev-parse --show-toplevel').toString().trim(); | ||
| const snippetsPath = path.join(gitRoot, 'snippets'); | ||
| const getChunk = async () => { | ||
| if (source.startsWith('http')) { | ||
| const data = await fetch(source).then((response) => response.text()); | ||
| return data; | ||
| } | ||
| const data = await fs.readFile(path.join(snippetsPath, l, source), {encoding: "utf8"}) | ||
| return data | ||
| } |
There was a problem hiding this comment.
Taken from @raducristianpopa's ChunkedSnippetExperimental #653.
mkurapov
commented
Sep 22, 2025
Comment on lines
+15
to
+18
| if (source.startsWith('http')) { | ||
| const data = await fetch(source).then((response) => response.text()); | ||
| return data; | ||
| } |
There was a problem hiding this comment.
For now, still allowing the http path to be fetched from the source. This is to support the PHP snippets in the meantime, which will be done in a separate PR
mkurapov
requested review from
melissahenderson,
hajjimo and
brad-dow
as code owners
melissahenderson
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Moving all of the NodeJS snippets from https://github.com/interledger/open-payments-snippets to
snippets/node, and updating theChunkedSnippetcomponent to use the local files, based off of #653.Fixes #668 | OPE-239
Required
Conditional