-
Notifications
You must be signed in to change notification settings - Fork 96
chore: add card-service and pos-service image build steps in CI #3657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pos-card-services
Are you sure you want to change the base?
Conversation
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs
|
"@types/koa-bodyparser": "^4.3.12", | ||
"@types/koa__cors": "^5.0.0", | ||
"@types/koa__router": "^12.0.4", | ||
"@types/node": "^20.14.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed this so that the pipeline can recognise crypto
library.
COPY package.json pnpm-workspace.yaml .npmrc ./ | ||
COPY packages/card-service/knexfile.js ./packages/card-service/knexfile.js | ||
COPY packages/card-service/package.json ./packages/card-service/package.json | ||
COPY packages/token-introspection/package.json ./packages/token-introspection/package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both card-service and POS service don't use the token-introspection
, so we can remove it from the Dockerfiles + package.json (and removing build:deps
)
description: Card expired or invalid signature | ||
'500': | ||
description: Internal server error | ||
description: 'POS service calls this endpoint to accept a payment request.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'POS service calls this endpoint to accept a payment request.' | |
description: 'POS service calls this endpoint to initiate a payment request.' |
|
||
# For additional paranoia, we make it so that the Rafiki user has no write access to the packages | ||
RUN chown -R :rafiki /home/rafiki/packages | ||
RUN chmod -R 750 /home/rafiki/packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing a CMD
here to run the app, same thing for the pos-service
one
@oana-lolea if you update |
Changes proposed in this pull request
card-service
andpoint-of-sale
images when pushing to Github registryContext
Fixes #3652 | RAF-1167
Checklist
fixes #number
user-docs
label (if necessary)