Skip to content

Conversation

oana-lolea
Copy link
Contributor

@oana-lolea oana-lolea commented Sep 19, 2025

Changes proposed in this pull request

  • Add card-service and point-of-sale images when pushing to Github registry

Context

Fixes #3652 | RAF-1167

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added the type: ci Changes to the CI label Sep 19, 2025
Copy link

github-actions bot commented Sep 19, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 40.88
  • Iterations/s: 13.64
  • Failed Requests: 0.00% (0 of 2457)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 887 kB 15 kB/s
     data_sent......................: 1.9 MB 31 kB/s
     http_req_blocked...............: avg=7.54µs   min=2.45µs   med=5.23µs   max=1.33ms   p(90)=6.37µs   p(95)=6.91µs  
     http_req_connecting............: avg=1.29µs   min=0s       med=0s       max=1.28ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=97.21ms  min=7.14ms   med=78.92ms  max=671.62ms p(90)=166.67ms p(95)=187.81ms
       { expected_response:true }...: avg=97.21ms  min=7.14ms   med=78.92ms  max=671.62ms p(90)=166.67ms p(95)=187.81ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2457
     http_req_receiving.............: avg=87.08µs  min=27.77µs  med=77.49µs  max=1.61ms   p(90)=111.9µs  p(95)=139.19µs
     http_req_sending...............: avg=33.82µs  min=11.81µs  med=28.13µs  max=957.96µs p(90)=41.15µs  p(95)=56.33µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=97.09ms  min=6.97ms   med=78.83ms  max=671.55ms p(90)=166.54ms p(95)=187.7ms 
     http_reqs......................: 2457   40.880496/s
     iteration_duration.............: avg=292.92ms min=171.47ms med=277.46ms max=1.2s     p(90)=354.19ms p(95)=384.21ms
     iterations.....................: 820    13.64347/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@github-actions github-actions bot added the type: tests Testing related label Sep 22, 2025
@github-actions github-actions bot removed the type: tests Testing related label Sep 23, 2025
"@types/koa-bodyparser": "^4.3.12",
"@types/koa__cors": "^5.0.0",
"@types/koa__router": "^12.0.4",
"@types/node": "^20.14.15",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed this so that the pipeline can recognise crypto library.

@oana-lolea oana-lolea marked this pull request as ready for review September 23, 2025 11:24
@oana-lolea oana-lolea requested a review from mkurapov September 23, 2025 11:24
COPY package.json pnpm-workspace.yaml .npmrc ./
COPY packages/card-service/knexfile.js ./packages/card-service/knexfile.js
COPY packages/card-service/package.json ./packages/card-service/package.json
COPY packages/token-introspection/package.json ./packages/token-introspection/package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both card-service and POS service don't use the token-introspection, so we can remove it from the Dockerfiles + package.json (and removing build:deps)

description: Card expired or invalid signature
'500':
description: Internal server error
description: 'POS service calls this endpoint to accept a payment request.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'POS service calls this endpoint to accept a payment request.'
description: 'POS service calls this endpoint to initiate a payment request.'

@oana-lolea oana-lolea requested a review from mkurapov September 23, 2025 14:04

# For additional paranoia, we make it so that the Rafiki user has no write access to the packages
RUN chown -R :rafiki /home/rafiki/packages
RUN chmod -R 750 /home/rafiki/packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing a CMD here to run the app, same thing for the pos-service one

@oana-lolea oana-lolea requested a review from mkurapov September 25, 2025 06:15
@mkurapov
Copy link
Contributor

@oana-lolea if you update pos-card-services branch and backmerge it into yours, you should see the security vulnerability fix there (which will end up passing the Docker Grype Scans)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: ci Changes to the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants