Skip to content

Conversation

@irees
Copy link
Contributor

@irees irees commented Sep 25, 2025

@irees irees requested a review from Copilot October 14, 2025 06:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances geography buffer functionality by adding dataset filtering support to census data operations. The changes enable more precise querying by allowing users to specify a particular census dataset when filtering geography data.

  • Added dataset parameter to census geography filters and corresponding GraphQL schema
  • Updated census value loading to include dataset filtering with null safety checks
  • Refactored buffer query logic to improve performance with proper CTE usage and simplified join structure

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
server/model/models_gen.go Added optional Dataset field to CensusDatasetGeographyFilter struct
server/model/finders.go Updated CensusValuesByGeographyIDs method signature to include dataset parameter
server/gql/loaders.go Modified loader to handle dataset parameter with null safety and updated parameter structure
server/finders/dbfinder/finder.go Removed unused checkRange function
server/finders/dbfinder/census.go Enhanced geography queries with dataset filtering, improved buffer logic, and optimized database operations
schema/graphql/schema.graphqls Added dataset input field to CensusDatasetGeographyFilter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@irees irees marked this pull request as ready for review October 14, 2025 07:48
@irees irees merged commit cbcf2cb into main Oct 14, 2025
6 checks passed
@irees irees deleted the more-geog-buffer-opts branch October 14, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve performance of stop search by geography/bbox

1 participant