Skip to content

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #1623. Adds a class icon button to the editor title bar when the editor contains a class. When clicked, a QuickPick appears with all members of that class, including inherited ones. Clicking on a member shows it in the editor.

all members

I initially tried to implement this as a tree view, which prompted me to make some architectural improvements. I kept those in because I think they are worth including. I consolidated three three onDidChangeActiveTextEditor handlers to a single one, and I added the existing tree views to the array of disposables so their resources get cleaned up properly.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. The way the symbol-class icon displays colored in the editor's action bar looks a bit weird, but that's not in our control. I'm going to open a VS Code issue about it. Approving this PR.

@gjsjohnmurray
Copy link
Contributor

Perhaps the changelog for this item should mention that the Show Class Documentation Preview command has been dropped from Command Palette and from the editor tab's context menu, but can still be found on the editor's action bar.

@isc-bsaviano
Copy link
Contributor Author

I will check to see if I can apply a color to that ThemeIcon. According to the docs the color is only used for TreeItems.

@isc-bsaviano
Copy link
Contributor Author

When I write up the CHANGELOG I'll add a second line for that

@isc-bsaviano
Copy link
Contributor Author

The way the symbol-class icon displays colored in the editor's action bar looks a bit weird, but that's not in our control.

There is no way for me to change the color of the icon in the command definition, so I will merge this

@isc-bsaviano isc-bsaviano merged commit 8346209 into intersystems-community:master Sep 22, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the fix-1623 branch September 22, 2025 11:03
@gjsjohnmurray
Copy link
Contributor

I will check to see if I can apply a color to that ThemeIcon. According to the docs the color is only used for TreeItems.

image

I think the CSS change in microsoft/vscode#170562 should probably have excluded the case where the codicons are used in monaco-action-bar elements, or maybe even in monaco-toolbar ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing one place to see all elements inherited from parent classes
3 participants