Refactor CSV editor extension to support auto-opening and improve con…

csvEditorHtml/browser/beforeDomLoadedBrowser.ts

@@ -61,7 +61,6 @@ var initialConfig: EditCsvConfig | undefined = {
 	initialNumbersStyle: 'en',
 	insertRowBehavior: 'keepRowKeepColumn',
 	insertColBehavior: 'keepRowKeepColumn',
-	initiallyIsInReadonlyMode: false,
 	hideOpenCsvEditorUiActions: false, //noop, has only effect if set inside the user settings (vs code extension)
 	openTableAndSelectCellAtCursorPos: "never",
 	pasteMode: 'normal',

csvEditorHtml/io.ts

@@ -540,7 +540,7 @@ function handleVsCodeMessage(event: { data: ReceivedMessageFromVsCode }) {
 		}
 
 		default: {
-			_error('received unknown message from vs code')
+			console.warn(`received unknown message from vs code: ${JSON.stringify(message)}`)
 			notExhaustiveSwitch(message)
 			break
 		}

csvEditorHtml/main.ts

@@ -230,7 +230,7 @@ let shouldApplyHasHeaderAfterRowsAdded = false
  * table is editable or not, also disables some related ui, e.g. buttons
  * set via {@link EditCsvConfig.initiallyIsInReadonlyMode}
  */
-let isReadonlyMode = false
+let isReadonlyMode = true
 
 /**
  * the original csv file has a layout and sometimes we use the original positions

csvEditorHtml/types.d.ts

@@ -309,14 +309,6 @@ type EditCsvConfig = {
 	 */
 	insertColBehavior: 'keepRowFocusNewColumn' | 'keepRowKeepColumn'
 
-	/**
-	 * table should start in readonly mode?
-	 * true: table is view only,
-	 * false: edit mode (normal)
-	 * NOTE that initial fixes (e.g. all rows should have the same length) are applied because readonly is only applied after/during the table is created
-	 */
-	initiallyIsInReadonlyMode: boolean
-
 	/**
 	 * false: hide the edit csv button and the file context menu action to open the editor (useful if you want to call this extension from another extension and show a custom button), 
 	 * true: show them

csvEditorHtml/ui.ts

@@ -2149,6 +2149,15 @@ function displayData(this: any, csvParseResult: ExtendedCsvParseResult | null, c
  * then we set the editor to has changes
  */
 function onAnyChange(changes?: CellChanges[] | null, reason?: string) {
+	/**
+	 * Previously, an asterisk (*) was shown indicating unsaved changes
+	 * even when no actual modifications were made.
+	 * This fix ignores cases where the reason is undefined
+	 * and no real changes have occurred.
+	 */
+	if (!reason && (!changes || changes.length === 0)) {
+		return;
+	}
 
 	//this is the case on init (because initial data set)
 	//also when we reset data (button)

csvEditorHtml/util.ts

@@ -1163,7 +1163,6 @@ function setupAndApplyInitialConfigPart1(initialConfig: EditCsvConfig | undefine
 	fixedRowsTopInfoSpan.innerText = fixedRowsTop + ''
 	fixedColumnsTopInfoSpan.innerText = fixedColumnsLeft + ''
 
-	isReadonlyMode = initialConfig.initiallyIsInReadonlyMode
 	_updateToggleReadonlyModeUi()
 
 	setNumbersStyleUi(initialConfig.initialNumbersStyle)